linux-kernel - Re: [PATCH v1 1/6] vgacon: Set VGA struct resource types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <2565753.xYX6ocSsJ7@amdc3058>
Date:   Wed, 03 Jan 2018 16:10:43 +0100
From:   Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     Jason Cooper <jason@...edaemon.net>,
        Marc Zyngier <marc.zyngier@....com>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        linux-kernel@...r.kernel.org, Ralf Baechle <ralf@...ux-mips.org>,
        Paul Mackerras <paulus@...ba.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        Ivan Kokshaysky <ink@...assic.park.msu.ru>,
        Thomas Gleixner <tglx@...utronix.de>,
        Yinghai Lu <yinghai@...nel.org>,
        Matt Turner <mattst88@...il.com>,
        Richard Henderson <rth@...ddle.net>
Subject: Re: [PATCH v1 1/6] vgacon: Set VGA struct resource types

On Monday, December 04, 2017 06:40:04 PM Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@...gle.com>
> 
> Set the resource type when we reserve VGA-related I/O port resources.
> 
> The resource code doesn't actually look at the type, so it inserts
> resources without a type in the tree correctly even without this change.
> But if we ever print a resource without a type, it looks like this:
> 
>   vga+ [??? 0x000003c0-0x000003df flags 0x0]
> 
> Setting the type means it will be printed correctly as:
> 
>   vga+ [io  0x000003c0-0x000003df]
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>

Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics