linux-kernel - Re: [PATCH net-next v2 4/4] net: mvpp2: 2500baseX support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 3 Jan 2018 16:20:36 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Antoine Tenart <antoine.tenart@...e-electrons.com>
Cc:     davem@...emloft.net, kishon@...com,
        gregory.clement@...e-electrons.com, linux@...linux.org.uk,
        mw@...ihalf.com, stefanc@...vell.com, ymarkman@...vell.com,
        thomas.petazzoni@...e-electrons.com,
        miquel.raynal@...e-electrons.com, nadavh@...vell.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2 4/4] net: mvpp2: 2500baseX support

> @@ -4612,6 +4616,9 @@ static int mvpp22_comphy_init(struct mvpp2_port *port)
>  	case PHY_INTERFACE_MODE_1000BASEX:
>  		mode = PHY_MODE_SGMII;
>  		break;
> +	case PHY_INTERFACE_MODE_2500BASEX:
> +		mode = PHY_MODE_2500SGMII;
> +		break;

I think this is the source of confusion with linux/phy.h and
linux/phy/phy.h.

What would PHY_INTERFACE_MODE_2500SGMII use?

Where is this all getting confused? Should the caller to
mvpp22_comphy_init() actually be passing PHY_INTERFACE_MODE_2500SGMII?
What is the MAC actually doing at this point? 2500BASEX or 2500SGMII?

At minimum there needs to be a comment that this is not a typ0,
otherwise you are going to get patches submitted to 'fix' this.

	Thanks
		Andrew