linux-kernel - RE: [v2] ASoC: max98373: Added Amplifier Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <BY2PR11MB083710A6A737AB9C862FC965E71E0@BY2PR11MB0837.namprd11.prod.outlook.com>
Date:   Wed, 3 Jan 2018 18:37:09 +0000
From:   Ryan Lee <RyanS.Lee@...imintegrated.com>
To:     Rob Herring <robh@...nel.org>
CC:     "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "perex@...ex.cz" <perex@...ex.cz>,
        "tiwai@...e.com" <tiwai@...e.com>, "arnd@...db.de" <arnd@...db.de>,
        "afd@...com" <afd@...com>,
        "robert.jarzmik@...e.fr" <robert.jarzmik@...e.fr>,
        "supercraig0719@...il.com" <supercraig0719@...il.com>,
        "jbrunet@...libre.com" <jbrunet@...libre.com>,
        "dannenberg@...com" <dannenberg@...com>,
        "romain.perier@...labora.com" <romain.perier@...labora.com>,
        "bryce.ferguson@...kwellcollins.com" 
        <bryce.ferguson@...kwellcollins.com>,
        "kuninori.morimoto.gx@...esas.com" <kuninori.morimoto.gx@...esas.com>,
        "m-stecklein@...com" <m-stecklein@...com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "ryan.lee.maxim@...il.com" <ryan.lee.maxim@...il.com>
Subject: RE: [v2] ASoC: max98373: Added Amplifier Driver


>-----Original Message-----
>From: Rob Herring [mailto:robh@...nel.org]
>Sent: Tuesday, December 26, 2017 3:33 PM
>To: Ryan Lee <RyanS.Lee@...imintegrated.com>
>Cc: lgirdwood@...il.com; broonie@...nel.org; mark.rutland@....com;
>perex@...ex.cz; tiwai@...e.com; arnd@...db.de; afd@...com;
>robert.jarzmik@...e.fr; supercraig0719@...il.com; jbrunet@...libre.com;
>dannenberg@...com; romain.perier@...labora.com;
>bryce.ferguson@...kwellcollins.com; kuninori.morimoto.gx@...esas.com; m-
>stecklein@...com; alsa-devel@...a-project.org; devicetree@...r.kernel.org;
>linux-kernel@...r.kernel.org; ryan.lee.maxim@...il.com
>Subject: Re: [v2] ASoC: max98373: Added Amplifier Driver
>
>EXTERNAL EMAIL
>
>
>
>On Mon, Dec 25, 2017 at 07:10:10AM -0800, Ryan Lee wrote:
>
>Needs a commit message.
>
>> Signed-off-by: Ryan Lee <ryans.lee@...imintegrated.com>
>> ---
>>
>> Changes since v1:
>>       * Removed 'codec' from 'max98373_priv' structure
>>               : Now 'max98373_set_clock' function use 'dai->codec.dev' instead of
>using 'max98373->codec.dev'.
>>       * Removed 'max98373_dai_set_sysclk' function
>>               : This function is not necessary. Removed 'sysclk' from
>'max98373_priv' as well.
>>       * Removed 'iface' from 'max98373_priv' structure
>>               : There is no function who refer max98373->iface variable.
>>       * Added SPDX-License-Identifier
>>
>>  .../devicetree/bindings/sound/max98373.txt         |  43 +
>
>Please split bindings to separate patch.
Thank you for the feedback.
I will split it.

>
>>  sound/soc/codecs/Kconfig                           |   5 +
>>  sound/soc/codecs/Makefile                          |   2 +
>>  sound/soc/codecs/max98373.c                        | 974
>+++++++++++++++++++++
>>  sound/soc/codecs/max98373.h                        | 212 +++++
>>  5 files changed, 1236 insertions(+)
>>  create mode 100644
>> Documentation/devicetree/bindings/sound/max98373.txt
>>  create mode 100644 sound/soc/codecs/max98373.c  create mode 100644
>> sound/soc/codecs/max98373.h
>>
>> diff --git a/Documentation/devicetree/bindings/sound/max98373.txt
>> b/Documentation/devicetree/bindings/sound/max98373.txt
>> new file mode 100644
>> index 0000000..22cd259
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/sound/max98373.txt
>> @@ -0,0 +1,43 @@
>> +Maxim Integrated MAX98373 Speaker Amplifier
>> +
>> +This device supports I2C.
>> +
>> +Required properties:
>> +
>> +  - compatible : should be one of the following
>> +    - "maxim,max98373"
>> +
>> +  - reg : the I2C address of the device.
>> +
>> +Optional properties:
>> +
>> +  - maxim,vmon-slot-no : slot number used to send voltage information
>> +                   or in inteleave mode this will be used as
>> +                   interleave slot.
>> +                   slot range : 0 ~ 15,  Default : 0
>> +
>> +  - maxim,imon-slot-no : slot number used to send current information
>> +                   slot range : 0 ~ 15,  Default : 0
>> +
>> +  - maxim,spkfb-slot-no : slot number used to send speaker feedback
>information
>> +                   slot range : 0 ~ 15,  Default : 0
>> +
>> +  - maxim,interleave-mode : When using two MAX98373 in a system it is
>> +                   possible to create ADC data that that will
>> +                   overflow the frame size. Digital Audio Interleave
>> +                   mode provides a means to output VMON and IMON data
>> +                   from two devices on a single DOUT line when running
>> +                   smaller frames sizes such as 32 BCLKS per LRCLK or
>> +                   48 BCLKS per LRCLK.
>> +                   Range : 0 (off), 1 (on),  Default : 0
>
>This can be boolean instead.
I will change this to boolean type.
>
>> +
>> +Example:
>> +
>> +codec: max98373@31 {
>> +   compatible = "maxim,max98373";
>> +   reg = <0x31>;
>> +   maxim,vmon-slot-no = <0>;
>> +   maxim,imon-slot-no = <1>;
>> +   maxim,spkfb-slot-no = <2>;
>> +   maxim,interleave-mode = <0>;
>> +};