linux-kernel - Re: [PATCH] dmaengine: qcom_hidma: simplify DT resource parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4169dc20-0c3d-d8b6-96ed-9b16c35be441@codeaurora.org>
Date:   Thu, 4 Jan 2018 18:34:34 -0500
From:   Sinan Kaya <okaya@...eaurora.org>
To:     Rob Herring <robh@...nel.org>, Vinod Koul <vinod.koul@...el.com>
Cc:     linux-kernel@...r.kernel.org, Andy Gross <andy.gross@...aro.org>,
        David Brown <david.brown@...aro.org>,
        Dan Williams <dan.j.williams@...el.com>,
        linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org,
        dmaengine@...r.kernel.org
Subject: Re: [PATCH] dmaengine: qcom_hidma: simplify DT resource parsing

On 1/4/2018 5:45 PM, Rob Herring wrote:
> The hidma driver open codes populating address and IRQ resources from DT.
> We have standard functions of_address_to_resource and of_irq_to_resource
> for this, so use them instead.
> 
> The DT binding states each child should have 2 addresses and 1 IRQ, so we
> can simplify the logic and do a fixed size resource allocation. Using the
> standard of_address_to_resource will also do any address translation which
> was missing.
> 
> Cc: Andy Gross <andy.gross@...aro.org>
> Cc: David Brown <david.brown@...aro.org>
> Cc: Dan Williams <dan.j.williams@...el.com>
> Cc: Vinod Koul <vinod.koul@...el.com>
> Cc: linux-arm-msm@...r.kernel.org
> Cc: linux-soc@...r.kernel.org
> Cc: dmaengine@...r.kernel.org
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
>  drivers/dma/qcom/hidma_mgmt.c | 61 +++++++++++--------------------------------
>  1 file changed, 15 insertions(+), 46 deletions(-)

Thanks, this certainly looks cleaner. Mine was mostly copy/paste from other examples.

Reviewed-by: Sinan Kaya <okaya@...eaurora.org>

-- 
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.