linux-kernel - Re: [PATCH] drm/vc4: Move IRQ enable to PM path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87mv1uv55v.fsf@anholt.net>
Date:   Wed, 03 Jan 2018 16:28:12 -0800
From:   Eric Anholt <eric@...olt.net>
To:     Stefan Schake <stschake@...il.com>,
        David Airlie <airlied@...ux.ie>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Cc:     linux-rpi-kernel@...ts.infradead.org,
        Stefan Schake <stschake@...il.com>
Subject: Re: [PATCH] drm/vc4: Move IRQ enable to PM path

Stefan Schake <stschake@...il.com> writes:

> We were calling enable_irq on bind, where it was already enabled previously
> by the IRQ helper. Additionally, dev->irq is not set correctly until after
> postinstall and so was always zero here, triggering a warning in 4.15.
> Fix both by moving the enable to the power management resume path, where we
> know there was a previous disable invocation during suspend.
>
> Fixes: 253696ccd613 ("drm/vc4: Account for interrupts in flight")
> Signed-off-by: Stefan Schake <stschake@...il.com>
> ---
> I tested replacing the enable/disable dance with just synchronize_irq,
> but that only made the original kernel OOPS more sporadic.

Reviewed and applied.  Thanks!

Somewhere on the infinite TODO list is to stop using the DRM IRQ helpers
and just install our IRQ handler on our own, which I think would have
avoided this trouble.

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)