linux-kernel - Re: [PATCH v4 3/7] ARM: davinci: fix duplicate clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e3beaac9-c583-b181-38a8-d0aa6db44045@ti.com>
Date:   Thu, 4 Jan 2018 16:42:58 +0530
From:   Sekhar Nori <nsekhar@...com>
To:     David Lechner <david@...hnology.com>,
        <linux-arm-kernel@...ts.infradead.org>
CC:     Kevin Hilman <khilman@...nel.org>, Adam Ford <aford173@...il.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 3/7] ARM: davinci: fix duplicate clocks

On Monday 01 January 2018 05:09 AM, David Lechner wrote:
> There are a number of clocks that were duplicated because they are used by
> more than one device. It is no longer necessary to do this since we are
> explicitly calling clk_register_clkdev() for each clock. In da830.c, some
> clocks were using the same LPSC, which would cause problems with reference
> counting, so these are combinded into one clock each. In da850.c the
> duplicate clocks had already been fixed by creating dummy child clocks, so
> these clocks are removed.
> 
> Signed-off-by: David Lechner <david@...hnology.com>

If we do end up keeping 2/7, this should be done before that - to avoid
retouching code that was just introduced.

Thanks,
Sekhar