linux-kernel - Re: [char-misc-next] mei: me: allow runtime pm for platform with D0i3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ff398866-b49e-c7e6-f55d-7e0818501e31@intel.com>
Date:   Thu, 4 Jan 2018 16:47:01 +0100
From:   "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>
To:     "Winkler, Tomas" <tomas.winkler@...el.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Usyskin, Alexander" <alexander.usyskin@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: [char-misc-next] mei: me: allow runtime pm for platform with D0i3

On 1/4/2018 9:27 AM, Winkler, Tomas wrote:
> mei: me: allow runtime pm for platform with
>> D0i3
>>
>> On 1/2/2018 11:01 AM, Tomas Winkler wrote:
>>>   From the pci power documentation:
>>> "The driver itself should not call pm_runtime_allow(), though.
>>> Instead, it should let user space or some platform-specific code do
>>> that (user space can do it via sysfs as stated above)..."
>>>
>>> However, the S0ix residency cannot be reached without MEI device
>>> getting into low power state. Hence, for mei devices that support
>>> D0i3, it's better to make runtime power management mandatory and not
>>> rely on the system integration such as udev rules.
>> It still is not mandatory with this change.  The default changes from "on" to
>> "auto", but still user space can change it back to "on".
> That's correct, maybe better statement would be  'default  setting' instead of 'mandatory'.
> I can respin the patch if needed, let me know.

Greg has applied it already it seems, so I guess that shouldn't be 
necessary. :-)

Thanks,
Rafael