linux-kernel - Re: PTI build regression with nvidia drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1801041923440.2127@nanos>
Date:   Thu, 4 Jan 2018 19:25:22 +0100 (CET)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Kees Cook <keescook@...gle.com>
cc:     LKML <linux-kernel@...r.kernel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Andy Lutomirski <luto@...nel.org>, x86@...nel.org
Subject: Re: PTI build regression with nvidia drivers

On Thu, 4 Jan 2018, Kees Cook wrote:
> 
> This was pointed out in a few places, but not forwarded to lkml yet that I saw:
> 
> https://devtalk.nvidia.com/default/topic/1028222/linux/lts-kernel-patch-for-intel-cpu-vulnerability-breaks-nvidia-driver/post/5230546
> 
> Before and after PTI, cpu_tlbstate is a GPL export:
> 
> $ git show v4.14:arch/x86/mm/init.c | grep cpu_tlbstate
> DEFINE_PER_CPU_SHARED_ALIGNED(struct tlb_state, cpu_tlbstate) = {
> EXPORT_SYMBOL_GPL(cpu_tlbstate);
> 
> But after PTI, inlining or something is dragging cpu_tlbstate into the
> open, causing build failures.
> 
> Technically, to avoid regressions for that module, we'll need to drop
> the GPL marking on that symbol, or find some other solution...

Correct. It's indirect via the tlbflush inlines. We'll fix it as usual. Sigh....

Thanks,

	tglx