linux-kernel - Re: [PATCH] perf tools: Fix compiling error in libunwind x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180104182554.GD14721@kernel.org>
Date:   Thu, 4 Jan 2018 15:25:54 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Wang Nan <wangnan0@...wei.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf tools: Fix compiling error in libunwind x86

Em Wed, Dec 06, 2017 at 01:50:40AM +0000, Wang Nan escreveu:
> Fix a compiling error:
> 
>  ...
>    CC       util/libunwind/x86_32.o
>  In file included from util/libunwind/x86_32.c:33:0:
>  util/libunwind/../../arch/x86/util/unwind-libunwind.c: In function 'libunwind__x86_reg_id':
>  util/libunwind/../../arch/x86/util/unwind-libunwind.c:110:11: error: 'EINVAL' undeclared (first use in this function)
>     return -EINVAL;
>             ^
>  util/libunwind/../../arch/x86/util/unwind-libunwind.c:110:11: note: each undeclared identifier is reported only once for each function it appears in
>  mv: cannot stat 'util/libunwind/.x86_32.o.tmp': No such file or directory
>  make[4]: *** [util/libunwind/x86_32.o] Error 1
>  make[3]: *** [util] Error 2
>  make[2]: *** [libperf-in.o] Error 2
>  make[1]: *** [sub-make] Error 2
>  make: *** [all] Error 2
> 
> It happens when libunwind-x86 feature is detected.

Thanks, simple enough, applied.

- Arnaldo
 
> Signed-off-by: Wang Nan <wangnan0@...wei.com>
> ---
>  tools/perf/arch/x86/util/unwind-libunwind.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/arch/x86/util/unwind-libunwind.c b/tools/perf/arch/x86/util/unwind-libunwind.c
> index 9c917f8..05920e3 100644
> --- a/tools/perf/arch/x86/util/unwind-libunwind.c
> +++ b/tools/perf/arch/x86/util/unwind-libunwind.c
> @@ -1,7 +1,7 @@
>  // SPDX-License-Identifier: GPL-2.0
>  
> -#ifndef REMOTE_UNWIND_LIBUNWIND
>  #include <errno.h>
> +#ifndef REMOTE_UNWIND_LIBUNWIND
>  #include <libunwind.h>
>  #include "perf_regs.h"
>  #include "../../util/unwind.h"
> -- 
> 2.10.1