linux-kernel - Re: [PATCH 5/7] x86: Use IBRS for firmware update path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1515099096.30693.19.camel@debian.org>
Date:   Thu, 04 Jan 2018 21:51:36 +0100
From:   Yves-Alexis Perez <corsac@...ian.org>
To:     Tim Chen <tim.c.chen@...ux.intel.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Andy Lutomirski <luto@...nel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Greg KH <gregkh@...uxfoundation.org>
Cc:     Dave Hansen <dave.hansen@...el.com>,
        Andrea Arcangeli <aarcange@...hat.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Arjan Van De Ven <arjan.van.de.ven@...el.com>,
        linux-kernel@...r.kernel.org, David Woodhouse <dwmw@...zon.co.uk>
Subject: Re: [PATCH 5/7] x86: Use IBRS for firmware update path

On Thu, 2018-01-04 at 09:56 -0800, Tim Chen wrote:
> @@ -44,6 +47,7 @@ static inline void apm_bios_call_asm(u32 func, u32 ebx_in,
> u32 ecx_in,
>                   "=S" (*esi)
>                 : "a" (func), "b" (ebx_in), "c" (ecx_in)
>                 : "memory", "cc");
> +       unprotected_formware_end();

Just an obvious typo (form/firm) but I thought I'd report it.
>  }
>  
>  static inline bool apm_bios_call_simple_asm(u32 func, u32 ebx_in,
> @@ -52,6 +56,7 @@ static inline bool apm_bios_call_simple_asm(u32 func, u32
> ebx_in,
>         int     cx, dx, si;
>         bool    error;
>  
> +       unprotected_firmware_begin();
>         /*
>          * N.B. We do NOT need a cld after the BIOS call
>          * because we always save and restore the flags.
> @@ -68,6 +73,7 @@ static inline bool apm_bios_call_simple_asm(u32 func, u32
> ebx_in,
>                   "=S" (si)
>                 : "a" (func), "b" (ebx_in), "c" (ecx_in)
>                 : "memory", "cc");
> +       unprotected_formware_end();
>         return error;
>  }

Same here.
-- 
Yves-Alexis
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)