linux-kernel - Re: checkpatch: Add test for keywords not starting on tabstops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 05 Jan 2018 09:30:27 +0100
From:   Sven Eckelmann <sven@...fation.org>
To:     Joe Perches <joe@...ches.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Andy Whitcroft <apw@...onical.com>,
        linux-kernel@...r.kernel.org, b.a.t.m.a.n@...ts.open-mesh.org
Subject: Re: checkpatch: Add test for keywords not starting on tabstops

On Donnerstag, 21. April 2016 12:41:37 CET Joe Perches wrote:
> It's somewhat common and in general a defect for c90 keywords to
> not start on a tabstop.
> 
> Add a test for this condition and warn when it occurs.

This seems to create some new false positives:

    WARNING: Statements should start on a tabstop
    #919: FILE: ./net/batman-adv/sysfs.c:919:
    +                                     char ifname[IFNAMSIZ])
    
    total: 0 errors, 1 warnings, 0 checks, 1251 lines checked

The code at this position is:

    /**
     * batadv_store_mesh_iface_finish() - store new hardif mesh_iface state
     * @net_dev: netdevice to add/remove to/from batman-adv soft-interface
     * @ifname: name of soft-interface to modify
     *
     * Changes the parts of the hard+soft interface which can not be modified under
     * sysfs lock (to prevent deadlock situations).
     *
     * Return: 0 on success, 0 < on failure
     */
    static int batadv_store_mesh_iface_finish(struct net_device *net_dev,
    					  char ifname[IFNAMSIZ])
    {
    	struct net *net = dev_net(net_dev);


I know, my mail client is most likely mangling the tabs - so better check
https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/tree/net/batman-adv/sysfs.c?id=72deacce011bde7475c90e6ee7d4c7d28c384873#n918

Problem seems to be the [IFNAMSIZ]

Kind regards,
	Sven

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)