linux-kernel - Re: [B.A.T.M.A.N.] checkpatch: Add test for keywords not starting on tabstops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <14031954.75OLCfGoXO@sven-edge>
Date:   Fri, 05 Jan 2018 09:43:59 +0100
From:   Sven Eckelmann <sven@...fation.org>
To:     b.a.t.m.a.n@...ts.open-mesh.org
Cc:     Joe Perches <joe@...ches.com>, Andy Whitcroft <apw@...onical.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [B.A.T.M.A.N.] checkpatch: Add test for keywords not starting on tabstops

On Freitag, 5. Januar 2018 09:30:27 CET Sven Eckelmann wrote:
> On Donnerstag, 21. April 2016 12:41:37 CET Joe Perches wrote:
> > It's somewhat common and in general a defect for c90 keywords to
> > not start on a tabstop.
> >
> > Add a test for this condition and warn when it occurs.
> 
> This seems to create some new false positives:
> 
>     WARNING: Statements should start on a tabstop
>     #919: FILE: ./net/batman-adv/sysfs.c:919:
>     +                                     char ifname[IFNAMSIZ])
>     
>     total: 0 errors, 1 warnings, 0 checks, 1251 lines checked
[...]

Grml, just noticed that I've replied to the wrong mail. This was of course introduced by 
http://lkml.kernel.org/r/1b5f97673f36595956ad43329f77bf1a5546d2ff.1513976662.git.joe@perches.com 
and not by this patch.

Kind regards,
	Sven
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)