linux-kernel - Re: [PATCH 2/7] x86/enter: MACROS to set/clear IBRS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1801051410200.1724@nanos>
Date:   Fri, 5 Jan 2018 14:19:04 +0100 (CET)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Tim Chen <tim.c.chen@...ux.intel.com>
cc:     Peter Zijlstra <peterz@...radead.org>,
        Andy Lutomirski <luto@...nel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Greg KH <gregkh@...uxfoundation.org>,
        Dave Hansen <dave.hansen@...el.com>,
        Andrea Arcangeli <aarcange@...hat.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Arjan Van De Ven <arjan.van.de.ven@...el.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/7] x86/enter: MACROS to set/clear IBRS

On Thu, 4 Jan 2018, Tim Chen wrote:
> On 01/04/2018 02:16 PM, Peter Zijlstra wrote:
> >> +	movl    \save_reg, %eax
> >> +	wrmsr
> >> +10:
> >> +.endm
> > 
> > Should not all those 10 things look like .Ldone_\@ or something ?
> > 
> 
> They are removed in patch 6 with .Ldone_\@

So we need to develop speculative review capabilities from now on?

Please get your act together and fold stuff to the right place upfront, so
we can concentrate on the actual implementation review.

Thanks,

	tglx