linux-kernel - Re: [PATCH] Input: stmfts,s6sy671

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180105164958.csojn6vhy72bwoac@dtor-ws>
Date:   Fri, 5 Jan 2018 08:49:58 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Andi Shyti <andi.shyti@...sung.com>
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        Andi Shyti <andi@...zian.org>
Subject: Re: [PATCH] Input: stmfts,s6sy671 - add SPDX identifier

Hi Andi,

On Fri, Jan 05, 2018 at 06:57:15PM +0900, Andi Shyti wrote:
> Hi Dmitry,
> 
> this is a kind ping, would you also mind giving me a feedback to

Yes, sorry. Could you please split the patch for each driver
individually? Also, until we have an update to the CodingStyle doc
mandating the C++ style comments, I'd prefer keeping the original style
of comments. So // for the SPDX line and /* */ for the rest.

Thanks!

> all the previous patches I sent?

Could you tell me what reviews I owe you? My mailbox keeps growing :(

> 
> Thanks,
> Andi
> 
> On Tue, Dec 12, 2017 at 04:41:49PM +0900, Andi Shyti wrote:
> > Replace the original license statement with the SPDX identifier.
> > 
> > Update also the copyright owner adding myself as co-owner of the
> > copyright.
> > 
> > Signed-off-by: Andi Shyti <andi.shyti@...sung.com>
> > ---
> >  drivers/input/touchscreen/s6sy761.c | 15 +++++----------
> >  drivers/input/touchscreen/stmfts.c  | 15 +++++----------
> >  2 files changed, 10 insertions(+), 20 deletions(-)
> > 
> > diff --git a/drivers/input/touchscreen/s6sy761.c b/drivers/input/touchscreen/s6sy761.c
> > index 26b1cb8a88ec..675efa93d444 100644
> > --- a/drivers/input/touchscreen/s6sy761.c
> > +++ b/drivers/input/touchscreen/s6sy761.c
> > @@ -1,13 +1,8 @@
> > -/*
> > - * Copyright (c) 2017 Samsung Electronics Co., Ltd.
> > - * Author: Andi Shyti <andi.shyti@...sung.com>
> > - *
> > - * This program is free software; you can redistribute it and/or modify
> > - * it under the terms of the GNU General Public License version 2 as
> > - * published by the Free Software Foundation.
> > - *
> > - * Samsung S6SY761 Touchscreen device driver
> > - */
> > +// SPDX-License-Identifier: GPL-2.0
> > +// Samsung S6SY761 Touchscreen device driver
> > +//
> > +// Copyright (c) 2017 Samsung Electronics Co., Ltd.
> > +// Copyright (c) 2017 Andi Shyti <andi.shyti@...sung.com>
> >  
> >  #include <asm/unaligned.h>
> >  #include <linux/delay.h>
> > diff --git a/drivers/input/touchscreen/stmfts.c b/drivers/input/touchscreen/stmfts.c
> > index c12d01899939..2a123e20a42e 100644
> > --- a/drivers/input/touchscreen/stmfts.c
> > +++ b/drivers/input/touchscreen/stmfts.c
> > @@ -1,13 +1,8 @@
> > -/*
> > - * Copyright (c) 2017 Samsung Electronics Co., Ltd.
> > - * Author: Andi Shyti <andi.shyti@...sung.com>
> > - *
> > - * This program is free software; you can redistribute it and/or modify
> > - * it under the terms of the GNU General Public License version 2 as
> > - * published by the Free Software Foundation.
> > - *
> > - * STMicroelectronics FTS Touchscreen device driver
> > - */
> > +// SPDX-License-Identifier: GPL-2.0
> > +// STMicroelectronics FTS Touchscreen device driver
> > +//
> > +// Copyright (c) 2017 Samsung Electronics Co., Ltd.
> > +// Copyright (c) 2017 Andi Shyti <andi.shyti@...sung.com>
> >  
> >  #include <linux/delay.h>
> >  #include <linux/i2c.h>
> > -- 
> > 2.15.1
> > 

-- 
Dmitry