linux-kernel - Re: [PATCH v2 8/8] x86: Use IBRS for firmware update path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180106085538.GB4380@kroah.com>
Date:   Sat, 6 Jan 2018 09:55:38 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Tim Chen <tim.c.chen@...ux.intel.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Andy Lutomirski <luto@...nel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Dave Hansen <dave.hansen@...el.com>,
        Andrea Arcangeli <aarcange@...hat.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Arjan Van De Ven <arjan.van.de.ven@...el.com>,
        David Woodhouse <dwmw@...zon.co.uk>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 8/8] x86: Use IBRS for firmware update path

On Fri, Jan 05, 2018 at 06:12:23PM -0800, Tim Chen wrote:
> From: David Woodhouse <dwmw@...zon.co.uk>
> 
> We are impervious to the indirect branch prediction attack with retpoline
> but firmware won't be, so we still need to set IBRS to protect
> firmware code execution when calling into firmware at runtime.
> 
> Signed-off-by: David Woodhouse <dwmw@...zon.co.uk>
> Signed-off-by: Tim Chen <tim.c.chen@...ux.intel.com>
> ---
>  arch/x86/include/asm/apm.h       |  6 ++++++
>  arch/x86/include/asm/efi.h       | 17 +++++++++++++--
>  arch/x86/include/asm/spec_ctrl.h |  3 +++
>  arch/x86/kernel/cpu/spec_ctrl.c  | 45 ++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 69 insertions(+), 2 deletions(-)

The files that Alan pointed out as being missed in the last version of
this patch don't seem to be updated here either :(

thanks,

greg k-h