linux-kernel - Re: [PATCH 0/3] eventfd: clean up unneeded cruft

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180106190048.GG21978@ZenIV.linux.org.uk>
Date:   Sat, 6 Jan 2018 19:00:48 +0000
From:   Al Viro <viro@...IV.linux.org.uk>
To:     Eric Biggers <ebiggers3@...il.com>
Cc:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Davide Libenzi <davidel@...ilserver.org>
Subject: Re: [PATCH 0/3] eventfd: clean up unneeded cruft

On Sat, Jan 06, 2018 at 06:46:19PM +0000, Al Viro wrote:
> On Sat, Jan 06, 2018 at 09:45:41AM -0800, Eric Biggers wrote:
> > This series removes some cruft (mainly exported functions) from
> > fs/eventfd.c which seems to have been added while the KVM irqfd feature
> > was under development some years ago, but was never actually used.
> 
> Applied.


Said that, is there any reason for keeping e.g. vhost_dev->log_file around?
We already keep ->log_ctx, so...  Ditto for vq->call and vq->error,
and if we did it for vq->kick as well, we'd be able to get rid of
separate eventfd_fget() as well.