linux-kernel - Re: [PATCH] pinctrl: mcp23s08: fix irq setup order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b8c00c49-5e87-1258-c51d-ed42f4871b42@electromag.com.au>
Date:   Mon, 8 Jan 2018 13:29:20 +0800
From:   Phil Reid <preid@...ctromag.com.au>
To:     Linus Walleij <linus.walleij@...aro.org>,
        Dmitry Mastykin <mastichi@...il.com>,
        Sebastian Reichel <sre@...nel.org>
Cc:     linux-gpio@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pinctrl: mcp23s08: fix irq setup order

On 2/01/2018 17:10, Linus Walleij wrote:
> On Thu, Dec 28, 2017 at 4:19 PM, Dmitry Mastykin <mastichi@...il.com> wrote:
> 
>> When using mcp23s08 module with gpio-keys, often (50% of boots)
>> it fails to get irq numbers with message:
>> "gpio-keys keys: Unable to get irq number for GPIO 0, error -6".
>> Seems that irqs must be setup before devm_gpiochip_add_data().
>>
>> Signed-off-by: Dmitry Mastykin <mastichi@...il.com>
> 
> Patch applied, albeit for devel.
> 
> Should it be tagged for stable or go into fixes?
> 
I'm no expert on this one, but looking at other drivers they're using a mixture of ordering
for irq setup and devm_gpiochip_add_data() calls.

But should probably go into stable if it is the fix.


-- 
Regards
Phil Reid