linux-kernel - Re: [PATCH v6 01/10] x86/retpoline: Add initial retpoline support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1515408782.7317.33.camel@infradead.org>
Date:   Mon, 08 Jan 2018 10:53:02 +0000
From:   David Woodhouse <dwmw2@...radead.org>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     Andi Kleen <ak@...ux.intel.com>, Paul Turner <pjt@...gle.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Greg Kroah-Hartman <gregkh@...ux-foundation.org>,
        Tim Chen <tim.c.chen@...ux.intel.com>,
        Dave Hansen <dave.hansen@...el.com>, tglx@...utronix.de,
        Kees Cook <keescook@...gle.com>,
        Rik van Riel <riel@...hat.com>,
        Andy Lutomirski <luto@...capital.net>,
        Jiri Kosina <jikos@...nel.org>, gnomes@...rguk.ukuu.org.uk
Subject: Re: [PATCH v6 01/10] x86/retpoline: Add initial retpoline support

On Mon, 2018-01-08 at 11:45 +0100, Peter Zijlstra wrote:
> 
> 
> Should this not use local name labels instead?
> 
> .macro RETPOLINE_JMP reg:req
>         call    .Ldo_rop_\@
> .Lspec_trap_\@:
>         pause
>         jmp .Lspec_trap_\@
> .Ldo_rop_\@:
>         mov     \reg, (%_ASM_SP)
>         ret
> .endm

Not if you want to be able to use them twice in the same .S file.
Download attachment "smime.p7s" of type "application/x-pkcs7-signature" (5213 bytes)