linux-kernel - Re: [PATCH] scsi: mptfusion: use strlcpy() instead of strncpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a2dF8NYPObQJwUpOmkpcPMQBanyqwxZz_oqPCKEW2Q_jw@mail.gmail.com>
Date:   Mon, 8 Jan 2018 17:43:02 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Xiongfeng Wang <wangxiongfeng2@...wei.com>
Cc:     Suganath Prabu Subramani <suganath-prabu.subramani@...adcom.com>,
        MPT-FusionLinux.pdl@...adcom.com,
        linux-scsi <linux-scsi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi: mptfusion: use strlcpy() instead of strncpy()

On Mon, Jan 8, 2018 at 1:49 PM, Xiongfeng Wang
<wangxiongfeng2@...wei.com> wrote:
> From: Xiongfeng Wang <xiongfeng.wang@...aro.org>
>
> gcc-8 reports
>
> drivers/message/fusion/mptbase.c: In function 'mpt_display_event_info':
> ./include/linux/string.h:245:9: warning: '__builtin_strncpy' specified
> bound 100 equals destination size [-Wstringop-truncation]
>
> We need to use strlcpy() to make sure the dest string is
> nul-terminated.
>
> Signed-off-by: Xiongfeng Wang <xiongfeng.wang@...aro.org>

Looks correct to me,

Acked-by: Arnd Bergmann <arnd@...db.de>