linux-kernel - Re: [PATCH] scsi: mptfusion: use strlcpy() instead of strncpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1shbfoi6k.fsf@oracle.com>
Date:   Mon, 08 Jan 2018 21:54:43 -0500
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Xiongfeng Wang <wangxiongfeng2@...wei.com>
Cc:     <suganath-prabu.subramani@...adcom.com>,
        <MPT-FusionLinux.pdl@...adcom.com>, <linux-scsi@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <arnd@...db.de>
Subject: Re: [PATCH] scsi: mptfusion: use strlcpy() instead of strncpy()


Xiongfeng,

> gcc-8 reports
>
> drivers/message/fusion/mptbase.c: In function 'mpt_display_event_info':
> ./include/linux/string.h:245:9: warning: '__builtin_strncpy' specified
> bound 100 equals destination size [-Wstringop-truncation]
>
> We need to use strlcpy() to make sure the dest string is
> nul-terminated.

Applied to 4.16/scsi-queue. Thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering