linux-kernel - Re: [PATCH 2/2] drivers: android: Fix logtags in methods

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20180109200348.GA28275@kroah.com>
Date:   Tue, 9 Jan 2018 21:03:48 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Harsh Shandilya <harsh@...kt.io>
Cc:     Arve Hjønnevåg <arve@...roid.com>,
        Harsh Shandilya <msfjarvis@...il.com>,
        Martijn Coenen <maco@...roid.com>,
        Todd Kjos <tkjos@...roid.com>, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] drivers: android: Fix logtags in methods

On Tue, Jan 09, 2018 at 07:45:33PM +0000, Harsh Shandilya wrote:
> On Tue 9 Jan, 2018, 10:32 PM Greg Kroah-Hartman, <gregkh@...uxfoundation.org>
> wrote:
> 
> > On Fri, Dec 22, 2017 at 07:37:03PM +0530, Harsh Shandilya wrote:
> > > From: Harsh Shandilya <harsh@...kt.io>
> > >
> > > Several methods in the driver were hardcoding
> > > the function name in their logging calls which
> > > is a checkpatch violation. Utilise the __func__
> > > macro to avoid needing to add the function name
> > > as is to the string.
> > >
> > > Test: logtags in dmesg remain unaffected before
> > > and after the patch.
> > >
> > > Signed-off-by: Harsh Shandilya <harsh@...kt.io>
> > >
> > > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > > Cc: "Arve Hjønnevåg" <arve@...roid.com>
> > > Cc: Todd Kjos <tkjos@...roid.com>
> > > Cc: Martijn Coenen <maco@...roid.com>
> > > Cc: devel@...verdev.osuosl.org
> > > Cc: linux-kernel@...r.kernel.org
> > > ---
> > >  drivers/android/binder.c | 13 +++++++------
> > >  1 file changed, 7 insertions(+), 6 deletions(-)
> >
> > Patch does not apply to my tree :(
> >
> 
> If you drop
> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git/commit/?h=char-misc-next&id=00c41cddebde8d1a635bf81a7b255b7e56fd0d15
> then the patch should go in cleanly. My patch includes the changes from
> Elad's already.

That patch came first in my inbox, I'm not going to revert it from the
tree now, sorry.

Just rebase and resend if your patch did "more".

thanks,

greg k-h