linux-kernel - Re: [PATCH] ASoC: codecs: dmic: Make number of channels configurable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180109041710.xjnyjvkxkrqhgnlg@rob-hp-laptop>
Date:   Mon, 8 Jan 2018 22:17:10 -0600
From:   Rob Herring <robh@...nel.org>
To:     Matthias Kaehlcke <mka@...omium.org>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Mark Rutland <mark.rutland@....com>,
        alsa-devel@...a-project.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, Bhumika Goyal <bhumirks@...il.com>,
        Arnaud Pouliquen <arnaud.pouliquen@...com>,
        huang lin <hl@...k-chips.com>,
        Brian Norris <briannorris@...omium.org>,
        Dylan Reid <dgreid@...omium.org>
Subject: Re: [PATCH] ASoC: codecs: dmic: Make number of channels configurable

On Fri, Jan 05, 2018 at 12:39:57PM -0800, Matthias Kaehlcke wrote:
> The DMIC DAI driver specifies a number of 1 to 8 channels for each DAI.
> The actual number of mics can currently not be configured in the device
> tree or audio glue, but is derived from the min/max channels of the CPU
> and codec DAI. A typical CPU DAI has two or more channels, in consequence
> a single mic is treated as a stereo/multi channel device, even though
> only one channel carries audio data.
> 
> This change adds the option to specify the number of used DMIC channels
> in the device tree. When specified this value overwrites the default
> channels_max value of 8 in the snd_soc_dai_driver struct of the codec.
> 
> Signed-off-by: Matthias Kaehlcke <mka@...omium.org>
> ---
>  Documentation/devicetree/bindings/sound/dmic.txt |  2 ++

Reviewed-by: Rob Herring <robh@...nel.org>

>  sound/soc/codecs/dmic.c                          | 24 +++++++++++++++++++++++-
>  2 files changed, 25 insertions(+), 1 deletion(-)