linux-kernel - Re: [PATCH] ION: Sys_heap: fix the incorrect pool->gfp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180109091428.sewxoc7vrtox33ai@mwanda>
Date:   Tue, 9 Jan 2018 12:14:28 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Chen Feng <puck.chen@...ilicon.com>
Cc:     Zeng Tao <prime.zeng@...ilicon.com>, labbott@...hat.com,
        sumit.semwal@...aro.org, gregkh@...uxfoundation.org,
        arve@...roid.com, tkjos@...roid.com, maco@...roid.com,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ION: Sys_heap: fix the incorrect pool->gfp_mask setting

On Tue, Jan 09, 2018 at 11:30:09AM +0800, Chen Feng wrote:
> 
> 
> On 2018/1/9 18:43, Zeng Tao wrote:
> > This issue is introduced by the commit <e7f63771b60e> ("ION: Sys_heap:
> > Add cached pool to spead up cached buffer alloc"),

Use the Fixes tag.

Fixes: e7f63771b60e ("ION: Sys_heap: Add cached pool to spead up cached buffer alloc")

> the gfp_mask low
> > order pool is overlapped by the high order inside the loop, so the
> > gfp_mask of all pools are set to high_order_gfp_flags.
> > 
> 
> Thanks
> > Signed-off-by: Zeng Tao <prime.zeng@...ilicon.com>
> > ---
> >  drivers/staging/android/ion/ion_system_heap.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/android/ion/ion_system_heap.c b/drivers/staging/android/ion/ion_system_heap.c
> > index 4dc5d7a..b6386be 100644
> > --- a/drivers/staging/android/ion/ion_system_heap.c
> > +++ b/drivers/staging/android/ion/ion_system_heap.c
> > @@ -298,10 +298,10 @@ static int ion_system_heap_create_pools(struct ion_page_pool **pools,
> >  					bool cached)
> >  {
> >  	int i;
> > -	gfp_t gfp_flags = low_order_gfp_flags;
> >  
> >  	for (i = 0; i < NUM_ORDERS; i++) {
> >  		struct ion_page_pool *pool;
> > +		gfp_t gfp_flags = low_order_gfp_flags;
> 
> Not define here. Better "gfp_flags = low_order_gfp_flags"

Either way is fine...

regards,
dan carpenter