linux-kernel - Re: [v2] net: gianfar_ptp: move set_fipers() to spinlock protecting area

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOMZO5CBoZ9pTr4bE61cYxdJ1tw1kWSi3miZD7KAcZ7oMcYoLA@mail.gmail.com>
Date:   Tue, 9 Jan 2018 07:15:18 -0200
From:   Fabio Estevam <festevam@...il.com>
To:     Yangbo Lu <yangbo.lu@....com>
Cc:     Claudiu Manoil <claudiu.manoil@....com>,
        Richard Cochran <richardcochran@...il.com>,
        netdev@...r.kernel.org, linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [v2] net: gianfar_ptp: move set_fipers() to spinlock protecting area

On Tue, Jan 9, 2018 at 1:02 AM, Yangbo Lu <yangbo.lu@....com> wrote:
> set_fipers() calling should be protected by spinlock in
> case that any interrupt breaks related registers setting
> and the function we expect. This patch is to move set_fipers()
> to spinlock protecting area in ptp_gianfar_adjtime().
>
> Signed-off-by: Yangbo Lu <yangbo.lu@....com>
> ---
> Changes for v2:
>         - explained why spinlock was needed in commit message.

Thanks for improving the commit log:

Reviewed-by: Fabio Estevam <fabio.estevam@....com>