linux-kernel - Re: [RESEND PATCH] mux: core: fix double get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180109102833.GC15608@kroah.com>
Date:   Tue, 9 Jan 2018 11:28:33 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Peter Rosin <peda@...ntia.se>
Cc:     Hans de Goede <hdegoede@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH] mux: core: fix double get_device()

On Mon, Jan 08, 2018 at 07:19:52PM +0100, Peter Rosin wrote:
> From: Hans de Goede <hdegoede@...hat.com>
> 
> class_find_device already does a get_device on the returned device.
> So the device returned by of_find_mux_chip_by_node is already referenced
> and we should not reference it again (and unref it on error).
> 
> Signed-off-by: Hans de Goede <hdegoede@...hat.com>
> Signed-off-by: Peter Rosin <peda@...ntia.se>
> ---
>  drivers/mux/core.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> Hi Greg,
> 
> Perhaps this was ignored due to more important stuff?

Yeah, the past few weeks have been a "bit" busy :(

I'll work to queue this up this week, sorry for the delay...

thanks,

greg k-h