linux-kernel - EDAC-AMD64: what is the ecc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <5dea4184-8782-7b57-2624-2957c91fe4ac@gmail.com>
Date:   Thu, 11 Jan 2018 00:06:49 +0100
From:   Gabriel C <nix.or.die@...il.com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: EDAC-AMD64: what is the ecc_msg good for ?

Hi Borislav,

while doing some testings with a EPYC box I notice
these strange messages when a Node is disabled.

I really do think the message is confusing since
we tell 'Node X: ... disabled' followed by a
INFO on the edac driver which tells the driver will not load.

Also even worse , we suggest to use ecc_enable_override then,
which can cause wrose things.. We really should not suggest
something like this by default.

So why this is still needed ?
I think is clear what 'Node X: .... disabled' means ?

Also if is still needed I suggest to chage that a bit like:

static const char *ecc_msg =
         "No ECC capability or ECC disabled in BIOS , module will not load.\n"

then add the node to the amd64_info()

	....

	if (!ecc_en || !nb_mce_en) {
		amd64_info("Node %d: %s", nid, ecc_msg);
	....

Or move that all to edac_dbg() ?

Regards,

Gabriel C