linux-kernel - Re: [PATCH v8 00/37] tracing: Inter-event (e.g. latency) support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180110054507.GB2575@danjae.aot.lge.com>
Date:   Wed, 10 Jan 2018 14:45:07 +0900
From:   Namhyung Kim <namhyung@...nel.org>
To:     Tom Zanussi <tom.zanussi@...ux.intel.com>
Cc:     rostedt@...dmis.org, tglx@...utronix.de, mhiramat@...nel.org,
        vedang.patel@...el.com, bigeasy@...utronix.de,
        joel.opensrc@...il.com, joelaf@...gle.com,
        mathieu.desnoyers@...icios.com, baohong.liu@...el.com,
        rajvi.jingar@...el.com, julia@...com, fengguang.wu@...el.com,
        linux-kernel@...r.kernel.org, linux-rt-users@...r.kernel.org,
        kernel-team@....com
Subject: Re: [PATCH v8 00/37] tracing: Inter-event (e.g. latency) support

On Thu, Dec 21, 2017 at 10:02:22AM -0600, Tom Zanussi wrote:
> Hi,
> 
> This is V8 of the inter-event tracing patchset, addressing input from
> V7.
> 
> These changes address Namhyung's most recent comments (thanks,
> Namhyung!) and move everything to the latest tracing/for-next:
> 
>   - moved a couple hunks switching hist_field_fn_t params from 15/37
>     (add variable support) to 20/37 (Pass tracing_map_elt to
>     hist_field_accessor)
>   - in hist_trigger_elt_data_alloc(), remove the unnecessary '+1' from
>     TASK_COMM_LEN size.
>   - simplified find_var_file() code according to Namhyung's
>     suggestions.
>   - fixed bug in print_synth_event() where entry->fields was being
>     used instead of the address as it should have been

I only have a nitpick in the patch 24 but otherwise cannot find an
issue anymore, so

Reviewed-by: Namhyung Kim <namhyung@...nel.org>

Thanks,
Namhyung