linux-kernel - Re: [PATCH 1/4] ASoC: max98373: Changed SPDX header in C++ comments style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5htvvuxbcr.wl-tiwai@suse.de>
Date:   Wed, 10 Jan 2018 11:21:56 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     "Mark Brown" <broonie@...nel.org>
Cc:     "Ryan Lee" <ryans.lee@...imintegrated.com>,
        <alsa-devel@...a-project.org>, <lgirdwood@...il.com>,
        <ryan.lee.maxim@...il.com>, <perex@...ex.cz>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/4] ASoC: max98373: Changed SPDX header in C++ comments style

On Wed, 10 Jan 2018 11:15:06 +0100,
Mark Brown wrote:
> 
> On Tue, Jan 09, 2018 at 09:01:58PM -0800, Ryan Lee wrote:
> 
> > @@ -1,4 +1,4 @@
> > -/* SPDX-License-Identifier: GPL-2.0 */
> > +// SPDX-License-Identifier: GPL-2.0
> >  /* Copyright (c) 2017, Maxim Integrated */
> 
> Please change the entire header to C++, mixing C and C++ on adjacent
> lines looks ugly.

I'm not sure whether it's a good direction to go, either.

I rather wonder why SPDX line *must* be in C++ comment style...


thanks,

Takashi