linux-kernel - Re: [PATCH 1/4] ASoC: max98373: Changed SPDX header in C++ comments style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180110102940.GA13207@sirena.org.uk>
Date:   Wed, 10 Jan 2018 10:29:40 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Takashi Iwai <tiwai@...e.de>
Cc:     Ryan Lee <ryans.lee@...imintegrated.com>,
        alsa-devel@...a-project.org, lgirdwood@...il.com,
        ryan.lee.maxim@...il.com, perex@...ex.cz,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] ASoC: max98373: Changed SPDX header in C++ comments
 style

On Wed, Jan 10, 2018 at 11:21:56AM +0100, Takashi Iwai wrote:
> Mark Brown wrote:
> > On Tue, Jan 09, 2018 at 09:01:58PM -0800, Ryan Lee wrote:

> > > @@ -1,4 +1,4 @@
> > > -/* SPDX-License-Identifier: GPL-2.0 */
> > > +// SPDX-License-Identifier: GPL-2.0
> > >  /* Copyright (c) 2017, Maxim Integrated */

> > Please change the entire header to C++, mixing C and C++ on adjacent
> > lines looks ugly.

> I'm not sure whether it's a good direction to go, either.

> I rather wonder why SPDX line *must* be in C++ comment style...

Apparently it's to remove any ambiguity for the tooling or something,
plus Linus decided he likes C++ comments.

I don't understand why this isn't done as a macro like MODULE_LICENSE()
and so on but the decision was rushed through and not really publicised
:9

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)