linux-kernel - Re: [PATCH v1 01/16] virtio: Validate queue pfn for 32bit transports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2aacb81b-0efb-87b9-f70c-a61e66dd0331@arm.com>
Date:   Wed, 10 Jan 2018 11:25:42 +0000
From:   Jean-Philippe Brucker <jean-philippe.brucker@....com>
To:     Peter Maydell <peter.maydell@...aro.org>,
        "Michael S. Tsirkin" <mst@...hat.com>
Cc:     Suzuki Poulose <Suzuki.Poulose@....com>,
        arm-mail-list <linux-arm-kernel@...ts.infradead.org>,
        kvm-devel <kvm@...r.kernel.org>,
        "kvmarm@...ts.cs.columbia.edu" <kvmarm@...ts.cs.columbia.edu>,
        Christoffer Dall <christoffer.dall@...aro.org>,
        Marc Zyngier <Marc.Zyngier@....com>,
        lkml - Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Kristina Martsenko <Kristina.Martsenko@....com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Radim Krčmář <rkrcmar@...hat.com>,
        Will Deacon <Will.Deacon@....com>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        Mark Rutland <Mark.Rutland@....com>,
        Catalin Marinas <Catalin.Marinas@....com>,
        Jason Wang <jasowang@...hat.com>,
        Christoffer Dall <cdall@...aro.org>
Subject: Re: [PATCH v1 01/16] virtio: Validate queue pfn for 32bit transports

Hi Peter,

On 10/01/18 11:19, Peter Maydell wrote:
> On 10 January 2018 at 11:06, Michael S. Tsirkin <mst@...hat.com> wrote:
>> For virtio-mmio? I don't seem to see that code in
>> hw/virtio/virtio-mmio.c
>> For example I still see handling for VIRTIO_MMIO_QUEUE_PFN
>> there, and no handling for VIRTIO_MMIO_QUEUE_DESC_LOW
>> and such.
> 
> Are there uses that make it worthwhile to get virtio-1
> support added to virtio-mmio, rather than just getting
> people to move over to virtio-pci instead ?

virtio-iommu uses virtio-mmio transport. It makes little sense to have an
IOMMU presented as a PCI endpoint.

Thanks,
Jean