linux-kernel - Re: [PATCH 11/33] dma-mapping: move swiotlb arch helpers to a new header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b0f90ed0-989f-4dc2-6f86-de8b4e486b55@arm.com>
Date:   Wed, 10 Jan 2018 15:31:08 +0000
From:   Robin Murphy <robin.murphy@....com>
To:     Christoph Hellwig <hch@....de>
Cc:     iommu@...ts.linux-foundation.org, linux-mips@...ux-mips.org,
        linux-ia64@...r.kernel.org, linux-sh@...r.kernel.org,
        sparclinux@...r.kernel.org, Guan Xuetao <gxt@...c.pku.edu.cn>,
        linux-arch@...r.kernel.org, linux-s390@...r.kernel.org,
        linux-c6x-dev@...ux-c6x.org, linux-hexagon@...r.kernel.org,
        x86@...nel.org, Konrad Rzeszutek Wilk <konrad@...nok.org>,
        linux-snps-arc@...ts.infradead.org,
        linux-m68k@...ts.linux-m68k.org, patches@...ups.riscv.org,
        linux-metag@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Michal Simek <monstr@...str.eu>, linux-parisc@...r.kernel.org,
        linux-cris-kernel@...s.com, linux-kernel@...r.kernel.org,
        linux-alpha@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH 11/33] dma-mapping: move swiotlb arch helpers to a new
 header

On 10/01/18 15:26, Christoph Hellwig wrote:
> On Wed, Jan 10, 2018 at 02:56:01PM +0000, Robin Murphy wrote:
>> I took a look at these, and it seems their phys_to_dma() usage is doing the
>> thing which we subsequently formalised as dma_map_resource(). I've had a
>> crack at a quick patch to update the CESA driver; qcom_nandc looks slightly
>> more complex in that the changes probably need to span the BAM dmaengine
>> driver as well.
> 
> Sounds great, although probably something for the next merge window.
> 
> In the meantime does this patch looks good to you?

Yes indeed, modulo Vladimir's comments - it does seem prudent to fix the 
obvious off-by-ones as we touch them. I've wanted to do something like 
this for ages, but never got around to it myself.

Thanks,
Robin.