linux-kernel - Re: [PATCH] uio_hv_generic: fix type mismatch warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a1WunyO4AqtDn=3BGy9d1=7wg5WUT6i2EzL5FT5s_+6Pw@mail.gmail.com>
Date:   Wed, 10 Jan 2018 18:14:08 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     "K. Y. Srinivasan" <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...uxdriverproject.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] uio_hv_generic: fix type mismatch warnings

On Wed, Jan 10, 2018 at 5:57 PM, Stephen Hemminger
<stephen@...workplumber.org> wrote:
> On Wed, 10 Jan 2018 17:42:38 +0100
> Arnd Bergmann <arnd@...db.de> wrote:
>
>> I moved the virt_to_phys() conversion into hv_uio_probe() as part of
>> a warning fix. Stephen's cleanup to remove the private mmap() function
>> seems reasonable, but part of it reverted the change that I did to
>> hide the warnings, so they are back now:
>>
>> drivers/uio/uio_hv_generic.c: In function 'hv_uio_probe':
>> drivers/uio/uio_hv_generic.c:123:5: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
>> drivers/uio/uio_hv_generic.c:130:5: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
>> drivers/uio/uio_hv_generic.c:136:5: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
>>
>> The type mismatch is now the result of the uio_mmap() definition, and
>> the best way I see from here is to shut them up with a uintptr_t cast.
>>
>> Fixes: 9c40546c012c ("uio_hv_generic: use standard mmap for resources")
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>
> Thanks. Not sure why I don't see these.
>
> Signed-off-by: Stephen Hemminger <sthemmin@...rosoft.com>

This is only on 32-bit targets with 64-bit phys_addr_t, which you don't normally
have on x86 in regular configurations, but it can happen in randconfig builds.

        Arnd