linux-kernel - Re: [PATCH 26/32] aio: refactor read/write iocb setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180111133832.GA5854@lst.de>
Date:   Thu, 11 Jan 2018 14:38:32 +0100
From:   Christoph Hellwig <hch@....de>
To:     Jeff Moyer <jmoyer@...hat.com>
Cc:     Christoph Hellwig <hch@....de>, viro@...iv.linux.org.uk,
        Avi Kivity <avi@...lladb.com>, linux-aio@...ck.org,
        linux-fsdevel@...r.kernel.org, netdev@...r.kernel.org,
        linux-api@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 26/32] aio: refactor read/write iocb setup

On Wed, Jan 10, 2018 at 04:19:53PM -0500, Jeff Moyer wrote:
> > +static int aio_prep_rw(struct kiocb *req, struct iocb *iocb)
> > +{
> > +	int ret;
> > +
> > +	req->ki_filp = fget(iocb->aio_fildes);
> > +	if (unlikely(!req->ki_filp))
> > +		return -EBADF;
> > +	req->ki_complete = aio_complete_rw;
> > +	req->ki_flags = 0;
> 
> The above assignment seems superfluous...

Thanks, fixed.