linux-kernel - Re: [PATCH 30/32] aio: add delayed cancel support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180111134358.GA5926@lst.de>
Date:   Thu, 11 Jan 2018 14:43:58 +0100
From:   Christoph Hellwig <hch@....de>
To:     Jeff Moyer <jmoyer@...hat.com>
Cc:     Christoph Hellwig <hch@....de>, viro@...iv.linux.org.uk,
        Avi Kivity <avi@...lladb.com>, linux-aio@...ck.org,
        linux-fsdevel@...r.kernel.org, netdev@...r.kernel.org,
        linux-api@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 30/32] aio: add delayed cancel support

On Wed, Jan 10, 2018 at 06:26:39PM -0500, Jeff Moyer wrote:
> >> The upcoming aio poll support would like to be able to complete the
> >> iocb inline from the cancellation context, but that would cause
> >> a lock order reversal.  Add support for optionally moving the cancelation
> >> outside the context lock to avoid this reversal.
> >>
> >> Signed-off-by: Christoph Hellwig <hch@....de>
> >
> > Acked-by: Jeff Moyer <jmoyer@...hat.com>
> 
> Actually, let's move these two defines:
> 
> #define AIO_IOCB_DELAYED_CANCEL (1 << 0)
> #define AIO_IOCB_CANCELLED      (1 << 1)
> 
> to include/linux/aio.h so that drivers outside of fs/aio.c can make use
> of them.

struct aio_kiocb is private to aio.c, so just exposing them won't
do anything useful.  If we really need these elsewhere we'll need
to come up with a proper interface.