linux-kernel - Re: [PATCH] null_blk: remove explicit 'select FAULT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <18843cd3-786f-b6c1-4d12-b89403cffe5c@kernel.dk>
Date:   Thu, 11 Jan 2018 07:57:53 -0700
From:   Jens Axboe <axboe@...nel.dk>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Hannes Reinecke <hare@...e.de>, Shaohua Li <shli@...com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] null_blk: remove explicit 'select FAULT_INJECTION'

On 1/11/18 3:31 AM, Arnd Bergmann wrote:
> Selecting FAULT_INJECTION causes a Kconfig warning when CONFIG_DEBUG_KERNEL
> is not set:
> 
> warning: (BLK_DEV_NULL_BLK && DRM_I915_SELFTEST) selects FAULT_INJECTION which has unmet direct dependencies (DEBUG_KERNEL)
> 
> The other drivers that use FAULT_INJECTION tend to have a separate
> Kconfig symbol for turning on that feature, so let's do the same
> thing here. This may add a bit more complexity than we like, but
> it avoids the warning and is more consistent with the rest of the
> kernel.

Thanks Arnd, I'll get this applied.

> diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
> index 622d9a2c8dae..b795d0ca74eb 100644
> --- a/drivers/block/Kconfig
> +++ b/drivers/block/Kconfig
> @@ -19,7 +19,10 @@ if BLK_DEV
>  config BLK_DEV_NULL_BLK
>  	tristate "Null test block driver"
>  	select CONFIGFS_FS
> -	select FAULT_INJECTION
> +
> +config BLK_DEV_NULL_BLK_FAULT_INJECTION
> +	bool "Support fault injection for Nll test block driver"
> +	depends on BLK_DEV_NULL_BLK && FAULT_INJECTION

Will fixup that typo.

-- 
Jens Axboe