linux-kernel - Re: [PATCH] perf evsel: Fix incorrect handling of type _TERM_DRV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180111145820.GA3025@kernel.org>
Date:   Thu, 11 Jan 2018 11:58:20 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Mathieu Poirier <mathieu.poirier@...aro.org>, ak@...ux.intel.com,
        peterz@...radead.org, mingo@...hat.com,
        alexander.shishkin@...ux.intel.com, namhyung@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf evsel: Fix incorrect handling of type _TERM_DRV_CFG

Em Thu, Jan 11, 2018 at 03:51:19PM +0100, Jiri Olsa escreveu:
> On Wed, Jan 10, 2018 at 01:46:51PM -0700, Mathieu Poirier wrote:
> > Commit ("d0565132605f perf evsel: Enable type checking for
> > perf_evsel_config_term types") assumes PERF_EVSEL__CONFIG_TERM_DRV_CFG
> > isn't used and as such adds a BUG_ON().
> > 
> > Since the enumeration type is used in macro ADD_CONFIG_TERM() the change
> > break CoreSight trace acquisition.
> > 
> > This patch restores the original code.
> > 
> > Signed-off-by: Mathieu Poirier <mathieu.poirier@...aro.org>
> 
> Acked-by: Jiri Olsa <jolsa@...nel.org>

Thanks, applied, and this affects only perf/core,

- Arnaldo