linux-kernel - Re: [PATCH] perf evsel: Fix incorrect handling of type _TERM_DRV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180111145119.GA20406@krava>
Date:   Thu, 11 Jan 2018 15:51:19 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Mathieu Poirier <mathieu.poirier@...aro.org>
Cc:     acme@...nel.org, ak@...ux.intel.com, peterz@...radead.org,
        mingo@...hat.com, alexander.shishkin@...ux.intel.com,
        namhyung@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf evsel: Fix incorrect handling of type _TERM_DRV_CFG

On Wed, Jan 10, 2018 at 01:46:51PM -0700, Mathieu Poirier wrote:
> Commit ("d0565132605f perf evsel: Enable type checking for
> perf_evsel_config_term types") assumes PERF_EVSEL__CONFIG_TERM_DRV_CFG
> isn't used and as such adds a BUG_ON().
> 
> Since the enumeration type is used in macro ADD_CONFIG_TERM() the change
> break CoreSight trace acquisition.
> 
> This patch restores the original code.
> 
> Signed-off-by: Mathieu Poirier <mathieu.poirier@...aro.org>

Acked-by: Jiri Olsa <jolsa@...nel.org>

thanks,
jirka

> ---
>  tools/perf/util/evsel.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
> index a4d256ea0dc4..b22071a20cd1 100644
> --- a/tools/perf/util/evsel.c
> +++ b/tools/perf/util/evsel.c
> @@ -781,7 +781,7 @@ static void apply_config_terms(struct perf_evsel *evsel,
>  			attr->write_backward = term->val.overwrite ? 1 : 0;
>  			break;
>  		case PERF_EVSEL__CONFIG_TERM_DRV_CFG:
> -			BUG_ON(1);
> +			break;
>  		default:
>  			break;
>  		}
> -- 
> 2.7.4
>