linux-kernel - Re: [PATCH] vfs: remove unused argument in iterate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180111150645.wqiz4zpklabriymh@quack2.suse.cz>
Date:   Thu, 11 Jan 2018 16:06:45 +0100
From:   Jan Kara <jack@...e.cz>
To:     Rakesh Pandit <rakesh@...era.com>
Cc:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Jan Kara <jack@...e.cz>
Subject: Re: [PATCH] vfs: remove unused argument in iterate_bdevs

On Thu 11-01-18 16:04:07, Rakesh Pandit wrote:
> @@ -2472,7 +2472,7 @@ static inline int thaw_bdev(struct block_device *bdev, struct super_block *sb)
>  	return 0;
>  }
>  
> -static inline void iterate_bdevs(void (*f)(struct block_device *, void *), void *arg)
> +static inline void iterate_bdevs(void (*f)(struct block_device *, void *))

You've missed the void * in (*f) prototype here. Other than that:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR