linux-kernel - Re: [PATCH] ASoC: sgtl5000: fix powerup/down of micbias-voltage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180111150704.GC7834@sirena.org.uk>
Date:   Thu, 11 Jan 2018 15:07:04 +0000
From:   Mark Brown <broonie@...nel.org>
To:     fischerc@...ssphone.de
Cc:     alsa-devel@...a-project.org, lgirdwood@...il.com, perex@...ex.cz,
        tiwai@...e.com, richard.leitner@...data.com, fabio.estevam@....com,
        bhumirks@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: sgtl5000: fix powerup/down of micbias-voltage

On Thu, Jan 11, 2018 at 09:40:31AM +0100, fischerc@...ssphone.de wrote:

> The mic-bias-voltage should get powered up/down automatically.
> Added missing DAPM_PRE and DAPM_POST widgets to fire up the mic_bias_event function.

> +	SND_SOC_DAPM_PRE("MIC_BIAS_PRE", mic_bias_event),
> +	SND_SOC_DAPM_POST("MIC_BIAS_POST", mic_bias_event),

I don't understand what this is intended to do.  The mic_bias_event()
callback is already hooked up to the Mic Bias supply widget, it should
be invoked whenever the bias is turned on and off already?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)