linux-kernel - Re: [PATCH] 8250_dw: do not int overflow when rate can not be aplied

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4fc98be4-e489-20f0-d899-e5eabdbd5e9d@sondrel.com>
Date:   Thu, 11 Jan 2018 18:03:36 +0000
From:   Ed Blake <ed.blake@...drel.com>
To:     Nuno Gonçalves <nunojpg@...il.com>
Cc:     gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        linux-serial@...r.kernel.org
Subject: Re: [PATCH] 8250_dw: do not int overflow when rate can not be aplied

On 11/01/18 17:55, Nuno Gonçalves wrote:
> So, for me clk_round_rate() always returns 24000000, and only the loop
> variable i changes, so the search is monotonic, from the highest baud
> to the lowest (increasing divider).
>
> I am using a Allwiner H2+, with the serial port configuration from
> sunxi-h3-h5.dtsi.
>
> Are you sure that clk_round_rate can return differet values? Is that
> because some boards might have several clock options beside the
> adjustable divider?

Yes I'm sure.  Some platforms allow the clock rate to be varied, hence
the existence of clk_round_rate() and clk_set_rate().

> I really need to understand what is the problem, to be able to suggest
> a solution to the integer overflow that is being allowed to happen.

Some sort of overflow check on i * max_rate could work?

> Thanks,
> Nuno