linux-kernel - Re: [PATCH] tools/testing: Fix trailing semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <97f5465b-1c18-5e1d-d84c-ce542d420540@kernel.org>
Date:   Thu, 11 Jan 2018 18:03:49 +0000
From:   Luis de Bethencourt <luisbg@...nel.org>
To:     shuah@...nel.org, linux-kernel@...r.kernel.org
Cc:     linux-kselftest@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Joe Perches <joe@...ches.com>,
        Shuah Khan <shuahkh@....samsung.com>
Subject: Re: [PATCH] tools/testing: Fix trailing semicolon

On 01/11/2018 05:21 PM, Shuah Khan wrote:
> On 01/11/2018 06:46 AM, Luis de Bethencourt wrote:
>> The trailing semicolon is an empty statement that does no operation.
>> Removing it since it doesn't do anything.
>>
>> Signed-off-by: Luis de Bethencourt <luisbg@...nel.org>
>> ---
>>
>> Hi Shuah,
>>
>> After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
>> suggested I fix it treewide [0].
>>
>> Best regards :)
>> Luis
>>
>>
>> [0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
>> [1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html
>>
>>  tools/testing/selftests/nsfs/pidns.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/nsfs/pidns.c b/tools/testing/selftests/nsfs/pidns.c
>> index 1182d4e437a2..e0d86e1668c0 100644
>> --- a/tools/testing/selftests/nsfs/pidns.c
>> +++ b/tools/testing/selftests/nsfs/pidns.c
>> @@ -70,7 +70,7 @@ int main(int argc, char *argv[])
>>  			return pr_err("NS_GET_PARENT returned a wrong namespace");
>>  
>>  		if (ioctl(pns, NS_GET_PARENT) >= 0 || errno != EPERM)
>> -			return pr_err("Don't get EPERM");;
>> +			return pr_err("Don't get EPERM");
>>  	}
>>  
>>  	kill(pid, SIGKILL);
>>
> 
> Thanks for the patch. I will take this in for 4.16-rc1.
> 
> thanks,
> -- Shuah
> 

Awesome. Thanks Shuah!
Luis