linux-kernel - Re: [PATCH v5 5/6] iommu/arm-smmu: Add support for qcom,smmu-v2 variant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e1ef7c93-aba4-e5e7-bb49-552316274439@codeaurora.org>
Date:   Fri, 12 Jan 2018 10:59:17 +0530
From:   Vivek Gautam <vivek.gautam@...eaurora.org>
To:     Rob Herring <robh@...nel.org>
Cc:     joro@...tes.org, mark.rutland@....com, rjw@...ysocki.net,
        gregkh@...uxfoundation.org, robdclark@...il.com,
        will.deacon@....com, robin.murphy@....com, sboyd@...eaurora.org,
        iommu@...ts.linux-foundation.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, freedreno@...ts.freedesktop.org,
        len.brown@...el.com, pavel@....cz, airlied@...ux.ie,
        sricharan@...eaurora.org, m.szyprowski@...sung.com,
        architt@...eaurora.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v5 5/6] iommu/arm-smmu: Add support for qcom,smmu-v2
 variant

Hi Rob,


On 01/12/2018 03:53 AM, Rob Herring wrote:
> On Tue, Jan 09, 2018 at 03:31:48PM +0530, Vivek Gautam wrote:
>> qcom,smmu-v2 is an arm,smmu-v2 implementation with specific
>> clock and power requirements. This smmu core is used with
>> multiple masters on msm8996, viz. mdss, video, etc.
>> Add bindings for the same.
>>
>> Signed-off-by: Vivek Gautam <vivek.gautam@...eaurora.org>
>> ---
>>
>>   * Major change in this patch -
>>     Changed compatible string from 'qcom,msm8996-smmu-v2' to
>>     'qcom,smmu-v2' to reflect the IP version rather than the
>>     platform on which it is used.
> The bugs and how things are connected are all the same? I'd suggest you
> keep both strings.

Sure,
     compatible = "qcom,msm8996-smmu-v2", "qcom,smmu-v2";

>
>>     The same IP is used across multiple platforms including msm8996,
>>     and sdm845 etc.
> But for only 2 or so platforms a fallback is not really worth it. You'll
> probably be on SMMUv3 before too long...
Right. There's msm8998 as well, but as you said keeping both strings
will make more sense.
Thanks.

Best regards
Vivek

[snip]

-- 
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project