linux-kernel - Re: [PATCH] IB/cma: use strlcpy() instead of strncpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180112114317.GL15760@mtr-leonro.local>
Date:   Fri, 12 Jan 2018 13:43:17 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     Xiongfeng Wang <wangxiongfeng2@...wei.com>
Cc:     jgg@...pe.ca, linux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org, arnd@...db.de
Subject: Re: [PATCH] IB/cma: use strlcpy() instead of strncpy()

On Fri, Jan 12, 2018 at 03:56:05PM +0800, Xiongfeng Wang wrote:
> From: Xiongfeng Wang <xiongfeng.wang@...aro.org>
>
> gcc-8 reports
>
> drivers/infiniband/core/cma_configfs.c: In function 'make_cma_dev':
> ./include/linux/string.h:245:9: warning: '__builtin_strncpy' specified
> bound 64 equals destination size [-Wstringop-truncation]
>
> We need to use strlcpy() to make sure the string is nul-terminated.
>
> Signed-off-by: Xiongfeng Wang <xiongfeng.wang@...aro.org>
> ---
>  drivers/infiniband/core/cma_configfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>


Thanks,
Reviewed-by: Leon Romanovsky <leonro@...lanox.com>

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)