linux-kernel - Re: [PATCH] IB/cma: use strlcpy() instead of strncpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180115230451.GA1867@ziepe.ca>
Date:   Mon, 15 Jan 2018 16:04:51 -0700
From:   Jason Gunthorpe <jgg@...pe.ca>
To:     Xiongfeng Wang <wangxiongfeng2@...wei.com>
Cc:     linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
        arnd@...db.de
Subject: Re: [PATCH] IB/cma: use strlcpy() instead of strncpy()

On Fri, Jan 12, 2018 at 03:56:05PM +0800, Xiongfeng Wang wrote:
> From: Xiongfeng Wang <xiongfeng.wang@...aro.org>
> 
> gcc-8 reports
> 
> drivers/infiniband/core/cma_configfs.c: In function 'make_cma_dev':
> ./include/linux/string.h:245:9: warning: '__builtin_strncpy' specified
> bound 64 equals destination size [-Wstringop-truncation]
> 
> We need to use strlcpy() to make sure the string is nul-terminated.
> 
> Signed-off-by: Xiongfeng Wang <xiongfeng.wang@...aro.org>
> Reviewed-by: Leon Romanovsky <leonro@...lanox.com>
>  drivers/infiniband/core/cma_configfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to rdma for-next, thanks

Jason