linux-kernel - Re: [PATCH v3] ftrace/module: Move ftrace_release_mod() to ddebug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180112173224.junllgodqu3jgu42@redbean>
Date:   Fri, 12 Jan 2018 18:32:27 +0100
From:   Jessica Yu <jeyu@...nel.org>
To:     rostedt@...dmis.org, Namit Gupta <gupta.namit@...sung.com>
Cc:     mingo@...hat.com, linux-kernel@...r.kernel.org,
        pankaj.m@...sung.com, a.sahrawat@...sung.com
Subject: Re: [PATCH v3] ftrace/module: Move ftrace_release_mod() to
 ddebug_cleanup label

+++ Namit Gupta [08/01/18 10:41 +0530]:
>ftrace_module_init happen after dynamic_debug_setup, it is desired that
>cleanup should be called after this label however in current implementation
>it is called in free module label,ie:even though ftrace in not initialized,
>from so many fail case ftrace_release_mod() will be called and unnecessary
>traverse the whole list.
>In below patch we moved ftrace_release_mod() from free_module label to
>ddebug_cleanup label. that is the best possible location, other solution
>is to make new label to ftrace_release_mod() but since ftrace_module_init()
>is not return with minimum changes it should be in ddebug_cleanup label.
>
>Signed-off-by: Namit Gupta <gupta.namit@...sung.com>

Hi Steven,

Could I get an ACK for this patch?

Thanks!

Jessica