linux-kernel - Re: [GIT pull] x86/pti updates for 4.15

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFzWgquv4i6Mab6bASqYXg3ErV3XDFEYf=GEcCDQg5uAtw@mail.gmail.com>
Date:   Sun, 14 Jan 2018 12:59:29 -0800
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Thomas Gleixner <tglx@...utronix.de>,
        David Woodhouse <dwmw@...zon.co.uk>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Greg KH <gregkh@...uxfoundation.org>
Subject: Re: [GIT pull] x86/pti updates for 4.15

On Sun, Jan 14, 2018 at 7:27 AM, Thomas Gleixner <tglx@...utronix.de> wrote:
>
>    git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86-pti-for-linus

So I do think this:

        $(warning CONFIG_RETPOLINE=y, but not supported by the
compiler. Toolchain update recommended.)

needs to be removed.

Yes, yes, I understand why it's warning. It's still both annoying and wrong.

It's wrong because it will just make people turn off RETPOLINE, and
the asm updates - and return stack clearing - that are independent of
the compiler are likely the most important parts because they are
likely the ones easiest to target.

And it's annoying because most people won't be able to do anything
about it. The number of people building their own compiler? Very
small. So if their distro hasn't got a compiler yet (and pretty much
nobody does), the warning is just annoying crap.

It is already properly reported as part of the sysfs interface. The
compile-time warning only encourages bad things.

             Linus