linux-kernel - Re: [PATCH 0/2] kconfig: 'if' and automatic submenu creation documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180114210048.GA11442@ravnborg.org>
Date:   Sun, 14 Jan 2018 22:00:48 +0100
From:   Sam Ravnborg <sam@...nborg.org>
To:     Ulf Magnusson <ulfalizer@...il.com>
Cc:     linux-kbuild@...r.kernel.org, yamada.masahiro@...ionext.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] kconfig: 'if' and automatic submenu creation
 documentation

Hi Ulf.

On Sun, Jan 14, 2018 at 12:33:43PM +0100, Ulf Magnusson wrote:
> These together should make the automatic submenu logic a lot clearer.
> 
> Ulf Magnusson (2):
>   kconfig: Document 'if' flattening logic
>   kconfig: Improve auto. menu documentation accuracy
> 
>  scripts/kconfig/menu.c | 33 +++++++++++++++++++++++++++++----
>  1 file changed, 29 insertions(+), 4 deletions(-)

Very good with extra comments in menu_finalize.
If you can mamage to explain the logic related to select
then even better.

While on the subject on improving readability, then
menu_finalize would benefit from a split in a number of
well named and well documented helper functions.

It would be great if you could try this out.

	Sam