linux-kernel - Re: [PATCH] watchdog: rave-sp: add NVMEM dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9fd661f1-6093-a6f3-6044-a32566abdbab@roeck-us.net>
Date:   Mon, 15 Jan 2018 10:00:29 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Arnd Bergmann <arnd@...db.de>, Lee Jones <lee.jones@...aro.org>
Cc:     Pavel Machek <pavel@....cz>,
        Nikita Yushchenko <nikita.yoush@...entembedded.com>,
        Andrey Smirnov <andrew.smirnov@...il.com>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] watchdog: rave-sp: add NVMEM dependency

On 01/15/2018 08:10 AM, Arnd Bergmann wrote:
> We can build this driver with or without NVMEM, but not built-in
> when NVMEM is a loadable module:
> 
> drivers/watchdog/rave-sp-wdt.o: In function `rave_sp_wdt_probe':
> rave-sp-wdt.c:(.text+0x27c): undefined reference to `nvmem_cell_get'
> rave-sp-wdt.c:(.text+0x290): undefined reference to `nvmem_cell_read'
> rave-sp-wdt.c:(.text+0x2c4): undefined reference to `nvmem_cell_put'
> 
> This adds a Kconfig dependency to enforce that.
> 
> Fixes: c3bb33345721 ("watchdog: Add RAVE SP watchdog driver")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>   drivers/watchdog/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 34d1c6851fa7..c09369f80989 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -226,6 +226,7 @@ config ZIIRAVE_WATCHDOG
>   config RAVE_SP_WATCHDOG
>   	tristate "RAVE SP Watchdog timer"
>   	depends on RAVE_SP_CORE
> +	depends on NVMEM || !NVMEM
>   	select WATCHDOG_CORE
>   	help
>   	  Support for the watchdog on RAVE SP device.
>