[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180115180055.GB2269@hirez.programming.kicks-ass.net>
Date: Mon, 15 Jan 2018 19:00:55 +0100
From: Peter Zijlstra <peterz@...radead.org>
To: Josh Poimboeuf <jpoimboe@...hat.com>
Cc: David Woodhouse <dwmw2@...radead.org>,
linux-kernel@...r.kernel.org, Dave Hansen <dave.hansen@...el.com>,
Ashok Raj <ashok.raj@...el.com>,
Thomas Gleixner <tglx@...utronix.de>,
Tim Chen <tim.c.chen@...ux.intel.com>,
Andy Lutomirski <luto@...nel.org>,
Linus Torvalds <torvalds@...ux-foundation.org>,
Greg KH <gregkh@...uxfoundation.org>,
Andrea Arcangeli <aarcange@...hat.com>,
Andi Kleen <ak@...ux.intel.com>,
Arjan Van De Ven <arjan.van.de.ven@...el.com>,
Dan Williams <dan.j.williams@...el.com>,
Paolo Bonzini <pbonzini@...hat.com>,
Jun Nakajima <jun.nakajima@...el.com>,
Asit Mallick <asit.k.mallick@...el.com>,
Borislav Petkov <bp@...en8.de>
Subject: Re: [PATCH 1/4] objtool: Implement base jump_assert support
On Mon, Jan 15, 2018 at 11:39:28AM -0600, Josh Poimboeuf wrote:
> Big props to you for braving the bowels of the objtool code.
>
> On Mon, Jan 15, 2018 at 05:44:29PM +0100, Peter Zijlstra wrote:
> > +static int read_jump_assertions(struct objtool_file *file)
>
> This does more than just _read_ the assertions. Can you call it
> something like assert_static_jumps() or do_static_jump_assertions() and
> then call it from the main check() function?
Sure.
> > --- a/tools/objtool/check.h
> > +++ b/tools/objtool/check.h
> > @@ -45,6 +45,7 @@ struct instruction {
> > unsigned char type;
> > unsigned long immediate;
> > bool alt_group, visited, dead_end, ignore, hint, save, restore, ignore_alts;
> > + bool br_static;
>
> s/br_static/static_jump_dest/?
fair enough.
> Also, fellow objtool expert, you forgot the patch to the MAINTAINERS
> file ;-)
Well, uhm.. I'll think about it ;-)
Powered by blists - more mailing lists