linux-kernel - Re: [PATCH v3 11/13] arm64: Implement branch predictor hardening for affected Cortex-A CPUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180115180127.jkwe6pbp4j7xcdhl@armageddon.cambridge.arm.com>
Date:   Mon, 15 Jan 2018 18:01:27 +0000
From:   Catalin Marinas <catalin.marinas@....com>
To:     Suzuki K Poulose <suzuki.poulose@....com>
Cc:     will.deacon@....com, mark.rutland@....com,
        lorenzo.pieralisi@....com, christoffer.dall@...aro.org,
        ard.biesheuvel@...aro.org, marc.zyngier@....com,
        linux-kernel@...r.kernel.org, shankerd@...eaurora.org,
        linux-arm-kernel@...ts.infradead.org, jnair@...iumnetworks.com
Subject: Re: [PATCH v3 11/13] arm64: Implement branch predictor hardening for
 affected Cortex-A CPUs

On Tue, Jan 09, 2018 at 04:12:18PM +0000, Suzuki K. Poulose wrote:
> arm64: capabilities: Handle duplicate entries for a capability
> 
> Sometimes a single capability could be listed multiple times with
> differing matches(), e.g, CPU errata for different MIDR versions.
> This breaks verify_local_cpu_feature() and this_cpu_has_cap() as
> we stop checking for a capability on a CPU with the first
> entry in the given table, which is not sufficient. Make sure we
> run the checks for all entries of the same capability. We do
> this by fixing __this_cpu_has_cap() to run through all the
> entries in the given table for a match and reuse it for
> verify_local_cpu_feature().
> 
> Cc: Mark Rutland <mark.rutland@....com>
> Cc: Will Deacon <will.deacon@....com>
> Cc: Marc Zyngier <marc.zyngier@....com>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@....com>
> ---
>  arch/arm64/kernel/cpufeature.c | 44 ++++++++++++++++++++++--------------------
>  1 file changed, 23 insertions(+), 21 deletions(-)

Applied. Thanks.

-- 
Catalin